Collect lang items in the AST #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * util/rust-hir-map.h: Keep a NodeId mappings for lang items. * util/rust-hir-map.cc (Mappings::insert_lang_item_node): New function. (Mappings::lookup_lang_item_node): Likewise.
gcc/rust/ChangeLog: * Make-lang.in: Add new object file. * rust-session-manager.cc (Session::compile_crate): Call CollectLangItems. * ast/rust-collect-lang-items.cc: New file. * ast/rust-collect-lang-items.h: New file.
CohenArthur
force-pushed
the
collect-lang-items-ast
branch
from
514c1f4 to
89425cf
Compare
gcc/rust/ChangeLog: * util/rust-attributes.h (class Attributes): New. * util/rust-attributes.cc: Implement Attributes::is_known(). * ast/rust-collect-lang-items.cc (is_known_attribute): Remove. (get_lang_item_attr): Call Attributes::is_known() instead. * hir/rust-ast-lower-base.cc (ASTLoweringBase::handle_outer_attributes): Likewise. (ASTLoweringBase::is_known_attribute): Remove.
CohenArthur
commented
Dec 4, 2024
Comment on lines
+1244
to
+1246
| // FIXME: Before merging: Should we remove the `locus` parameter here? since | ||
| // lang items are looked up mostly for code generation, it doesn't make sense to | ||
| // error out on the locus of the node trying to access an inexistant lang item |
There was a problem hiding this comment.
This would require changes in a lot of code which fetches lang items, such as the typechecker and codegen. It would be done in a later PR
P-E-P
approved these changes
Dec 4, 2024
| continue; | ||
| } | ||
|
|
||
| bool is_lang_item = str_path == Values::Attributes::LANG |
There was a problem hiding this comment.
We should introduce some helper function here instead, I'm sure it would be reused elsewhere and it would ease this function a bit.
Probably within rust-attributes.cc since we already have some similar functions there ?
There was a problem hiding this comment.
Yeah I think it'd be good but in a different PR. it would be a good good-first-pr issue too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have lang items paths, we need to be able to resolve these lang items to their definition point which is impossible in the current system, as lang items are only saved in the mappings during lowering (and thus after name resolution). This small visitor collects lang items and stores their NodeIds in the mappings for an easy resolution.