Skip to content

Apply #1556 on master #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2022
Merged

Apply #1556 on master #1585

merged 4 commits into from
Oct 26, 2022

Conversation

@CohenArthur
Copy link
Member

@CohenArthur CohenArthur commented Oct 12, 2022

We should probably wonder about our usage of -Wno-unused-parameter :)

@CohenArthur CohenArthur added the upstream Issue regarding upstreaming gccrs into GCC label Oct 12, 2022
@CohenArthur CohenArthur requested a review from philberty October 12, 2022 13:20
@CohenArthur CohenArthur marked this pull request as ready for review October 12, 2022 13:20
@CohenArthur CohenArthur force-pushed the apply-1556-master branch 2 times, most recently from 618706d to d1c4084 Compare October 24, 2022 13:25
@CohenArthur
Copy link
Member Author

CohenArthur commented Oct 25, 2022

@abbasfaisal I commented out a bunch of code from the constant evaluator in order to avoid some warnings. If you want I can open up some issues to put it back in at some point

@CohenArthur
Copy link
Member Author

CohenArthur commented Oct 26, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 26, 2022

Build succeeded:

@bors bors bot merged commit 14c942c into Rust-GCC:master Oct 26, 2022
@CohenArthur CohenArthur deleted the apply-1556-master branch October 26, 2022 09:02
tschwinge added a commit that referenced this pull request Dec 14, 2022
@tschwinge
Revert "ci: Apply warnings in CI"
1664a73 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
tschwinge added a commit that referenced this pull request Dec 14, 2022
@tschwinge
Revert "bors: Fix warning list"
a42212a 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
@tschwinge tschwinge mentioned this pull request Dec 14, 2022
Merged
bors bot added a commit that referenced this pull request Dec 14, 2022
@bors @tschwinge
Merge #1701
3d6dbb6 
1701: Standardize warning flags r=tschwinge a=tschwinge

Bring in #1670, revert #1623 and parts of #1585.


Co-authored-by: Thomas Schwinge <thomas@codesourcery.com>
tschwinge added a commit that referenced this pull request Dec 4, 2024
@tschwinge
Revert "ci: Apply warnings in CI"
7aa369c 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
tschwinge added a commit that referenced this pull request Dec 4, 2024
@tschwinge
Revert "bors: Fix warning list"
62c1ba0 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Mar 10, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
bad6309 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Mar 10, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
e516494 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Apr 28, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
99ac898 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Apr 28, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
ca6d738 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Apr 29, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
f26e004 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Apr 29, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
cb46917 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Apr 29, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
652c886 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Apr 29, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
2faeb51 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit to dkm/gccrs that referenced this pull request Sep 14, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
b36f0c1 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts Rust-GCC#1585 commit a32ef7a.
dkm pushed a commit to dkm/gccrs that referenced this pull request Sep 14, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
01d9f88 
This reverts Rust-GCC#1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit to dkm/gccrs that referenced this pull request Sep 14, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
bed570d 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts Rust-GCC#1585 commit a32ef7a.
dkm pushed a commit to dkm/gccrs that referenced this pull request Sep 14, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
487dbf2 
This reverts Rust-GCC#1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit to dkm/gccrs that referenced this pull request Sep 16, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
0adee62 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts Rust-GCC#1585 commit a32ef7a.
dkm pushed a commit to dkm/gccrs that referenced this pull request Sep 16, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
5c7a979 
This reverts Rust-GCC#1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit to dkm/gccrs that referenced this pull request Oct 8, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
d4692fc 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts Rust-GCC#1585 commit a32ef7a.
dkm pushed a commit to dkm/gccrs that referenced this pull request Oct 8, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
5e781a6 
This reverts Rust-GCC#1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Oct 8, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
91320a8 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Oct 8, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
0a027c2 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Oct 9, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
cdc00dc 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Oct 9, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
8c21fe9 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Oct 27, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
f40b9f0 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Oct 27, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
faf0294 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Oct 31, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
227e1ec 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Oct 31, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
9af36a8 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Nov 11, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
f142c9a 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Nov 11, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
c94a5a1 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Nov 12, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
e05a53a 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Nov 12, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
f53b52a 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Nov 17, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
0b4fadd 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Nov 17, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
2d599b6 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Nov 18, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
1d9ad0f 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Nov 18, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
55e546a 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Nov 25, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
a569d5c 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Nov 25, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
006521d 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Nov 25, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
5208fa5 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Nov 25, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
99b48ab 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
dkm pushed a commit that referenced this pull request Dec 1, 2025
@tschwinge @dkm
Revert "ci: Apply warnings in CI"
5416180 
As discussed in
<https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:

> '-Werror=overloaded-virtual' is implied as by default, we have
> '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
> ([...])
> (Maybe that isn't active for '--disable-bootstrap' builds, but that's
> "OK".)

For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
new such diagnostics will be caught by the #1026 "check for new warnings"
machinery, so effectively that does implement '-Werror', too.

> '-Wno-unused-parameter' [did] move into
> 'rust-warn'

This reverts #1585 commit a32ef7a.
dkm pushed a commit that referenced this pull request Dec 1, 2025
@tschwinge @dkm
Revert "bors: Fix warning list"
16d5541 
This reverts #1585 commit 94d1116.

Conflicts:
	.github/bors_log_expected_warnings
... manually resolved and adjusted; let's see...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philberty philberty Awaiting requested review from philberty

Assignees

No one assigned

Labels

upstream Issue regarding upstreaming gccrs into GCC

Projects

None yet

Milestone

Initial upstream patches

Development

Successfully merging this pull request may close these issues.

1 participant

@CohenArthur