Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Codepoint to gcc/rust/util/ #2530

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Move Codepoint to gcc/rust/util/ #2530

merged 1 commit into from
Aug 11, 2023

Conversation

tamaroning
Copy link
Contributor

@tamaroning tamaroning commented Aug 6, 2023 •
edited
Loading

depends on #2489

gccrs: Move Codepoint to gcc/rust/util/
gcc/rust/ChangeLog:

	* lex/rust-codepoint.h: Moved to...
	* util/rust-codepoint.h: ...here.
	* lex/rust-input-source.h: Add missing license
	* util/rust-unicode.cc: Add missing license

@tamaroning tamaroning changed the title Move codepoint to gcc/rust/util/ Move Codepoint to gcc/rust/util/ Aug 6, 2023
@tamaroning tamaroning mentioned this pull request Aug 7, 2023
Merged
@P-E-P P-E-P self-requested a review August 9, 2023 11:34
@P-E-P P-E-P added this to the GCC 14 Stage 3 milestone Aug 9, 2023
P-E-P
P-E-P approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this once conflicts are fixed. Nice work!

@tamaroning
Copy link
Contributor Author

rebased on master

@P-E-P
Copy link
Member

P-E-P commented Aug 11, 2023

rebased on master

Looks like some errors appeared post-rebase

@tamaroning
gccrs: clean up Codepoint and InputSource
ae4d3d2 
gcc/rust/ChangeLog:

	* lex/rust-codepoint.h: Moved to...
	* util/rust-codepoint.h: ...here.
	* lex/rust-input-source.h: Add missing license
	* util/rust-unicode.cc: Add missing license
	* util/rust-punycode.cc (extract_basic_string): Remove constant

Signed-off-by: Raiki Tamura <tamaron1203@gmail.com>
@P-E-P P-E-P added this pull request to the merge queue Aug 11, 2023
Merged via the queue into Rust-GCC:master with commit 2b1d37c Aug 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
libcore 1.49
Status: Done
Milestone
GCC 14 Stage 3
Development

Successfully merging this pull request may close these issues.
2 participants
@tamaroning @P-E-P