Handle nested macro definition (resolver) #2537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-E-P
changed the title
P-E-P
force-pushed
the
nested_macro_definition
branch
from
0dcb3d0
to
088e4a6
Compare
We need to collect the early resolver's macros error to emit them at a later stage after further expansion in order to retrieve macros defined by other macro invocations. gcc/rust/ChangeLog: * resolve/rust-early-name-resolver-2.0.cc (Early::visit): Collect error instead of emitting it. * resolve/rust-early-name-resolver-2.0.h (std::function<void): Add type definition for collection. * rust-session-manager.cc (Session::expansion): Collect errors while fixed point is not reached then emit remaining errors. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
P-E-P
force-pushed
the
nested_macro_definition
branch
from
088e4a6
to
95a11db
Compare
CohenArthur
approved these changes
Aug 16, 2023
Comment on lines
+138
to
+141
| collect_error ([&] () { | ||
| rust_error_at (invoc.get_locus (), ErrorCode::E0433, | ||
| "could not resolve macro invocation"); | ||
| }); |
There was a problem hiding this comment.
we can use @MahadMuhammad's new Error constructor instead of this lambda, which should help clean up the code
|
We'll use mapping instead. Check #2541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2516
This PR clashes with #2541 we need to decide which one get merged. Per
This is still an early draft, I don't really know where I am going with this one. @CohenArthur could you give me more details about what you had in mind with this comment ?