Support for rich-loc & errorcode in parser & expansion errors
#2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahadMuhammad
force-pushed
the
parser-error
branch
from
c4f5e5f to
d08152e
Compare
MahadMuhammad
commented
Aug 11, 2023
MahadMuhammad
force-pushed
the
parser-error
branch
from
d08152e to
b1eee3f
Compare
Added method of binding ErrorCode & rich location to parser and expansion errors. Fixes Rust-GCC#2385 gcc/rust/ChangeLog: * rust-diagnostics.cc (va_constructor): Added constructor for all possible cases. (Error::Error): Updated error struct for all possible cases. * rust-diagnostics.h (struct Error): Updated error struct to support error code & rich location support. Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
force-pushed
the
parser-error
branch
from
b1eee3f to
1338a41
Compare
MahadMuhammad
commented
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding
rich-loc&errorcodein parser & expansion errorsAdded method of binding ErrorCode & rich location to parser and expansion errors.
Currently, the
Errorstruct only supports simple location toparserandexpansionerrors. Updated the code to handle all cases forerrorcodeandparsingerrors. Now, we can rich-loation toErrorstruct by using ampersand&operator.The
rust_error_atfunction immediately emits the error. But in some contexts we wish to collect them and discard them. Now, we can use errorcode and rich location inErrorstruct's context.gcc/rust/ChangeLog: