[E0164] Neither tuple struct nor tuple variant used as a pattern #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if pattern has items, before returing solves ICE. Added error code and rich location. Also, fixes Rust-GCC#2430 gcc/rust/ChangeLog: * ast/rust-pattern.h: No need of assertion, we are handling it. * resolve/rust-early-name-resolver.cc (EarlyNameResolver::visit): Added check which emits error instead of using assertion. * typecheck/rust-hir-type-check-pattern.cc (TypeCheckPattern::visit): Added rich location and error code. gcc/testsuite/ChangeLog: * rust/compile/match5.rs: Updated comment for dejagnu. * rust/compile/pattern-struct.rs: New test for ICE. Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
MahadMuhammad
commented
Aug 16, 2023
| rust_error_at ( | ||
| pattern.get_locus (), | ||
| rich_locus, ErrorCode::E0164, |
There was a problem hiding this comment.
Here, rustc 1.49.0 emits E0532 & rustc 1.71.0 emits E0164
There was a problem hiding this comment.
Good catch. Go with the latest one
There was a problem hiding this comment.
Added the latest one :)
philberty
reviewed
Aug 17, 2023
| rust_assert (has_items ()); | ||
| return items; | ||
| } | ||
| std::unique_ptr<TupleStructItems> &get_items () { return items; } |
There was a problem hiding this comment.
Good find @dkm has been fixing these too. Keep your eye out for them :D
CohenArthur
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither a tuple struct nor a tuple variant was used as a pattern -
E0164Checking if pattern has items, before returing solves ICE. Added error code and rich location.
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: