Inline asm resolve expr #3109
Merged
Inline asm resolve expr #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For HIR::TypeCheckExpr, this weirdly depends on #3060 since asm_generic_il implements the hir visitor pattern for inline asm. To break dependency I think i'll implement hir type check inside asm_generic_il. @CohenArthur thoughts? |
badumbatish
force-pushed
the
inline_asm_name_res_typeck
branch
from
031bb64
to
f9a3851
Compare
gcc/rust/ChangeLog: * resolve/rust-ast-resolve-expr.cc (ResolveExpr::visit): Implement resolve expr for inline asm ast (translate_operand): Likewise. * resolve/rust-ast-resolve-expr.h: Likewise.
badumbatish
force-pushed
the
inline_asm_name_res_typeck
branch
from
f9a3851
to
d890d7d
Compare
CohenArthur
approved these changes
Aug 2, 2024
that's fine with me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve InlineAsm through its operand, depends on #3103
Relevant file for review is rust-ast-resolve-expr.h/cc