Add glibcxx_assertion check #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badumbatish
force-pushed
the
glibcxx_ci
branch
2 times, most recently
from
90e23b4
to
2f4d12d
Compare
|
will try again tmr |
badumbatish
force-pushed
the
glibcxx_ci
branch
from
2f4d12d
to
bbaffc2
Compare
|
fixed by adding a boolean check of binder.empty() |
ChangeLog: * .github/workflows/ccpp.yml: Add glibcxx_assertion check * .github/glibcxx_ubuntu64b_log_expected_warnings: New file.
gcc/rust/ChangeLog: * typecheck/rust-hir-type-check.h: Add pop guard for binder
badumbatish
force-pushed
the
glibcxx_ci
branch
from
bbaffc2
to
a74de7f
Compare
CohenArthur
approved these changes
Aug 28, 2024
Comment on lines
+148
to
+155
| cd gccrs-build | ||
| < log grep 'warning: ' | sort > log_warnings | ||
| if diff -U0 ../.github/glibcxx_ubuntu64b_log_expected_warnings log_warnings; then | ||
| : | ||
| else | ||
| echo 'See <https://github.com/Rust-GCC/gccrs/pull/1026>.' | ||
| exit 1 | ||
| fi >&2 |
There was a problem hiding this comment.
so do we need a different expected warnings file? are there more warnings when GLIBCXX_ASSERTIONS is defined?
There was a problem hiding this comment.
the default ubuntu 64 bit has a few more warnings than when we run it with GLIBCXX_ASSERTIONS, thus triggering failure when CI is run. Should we use a different diff at line 150?
There was a problem hiding this comment.
no worries, that's completely fine - I wasn't aware that using the define would result in more warnings, and I thought the two files would end up the same, but if that's not the case then this one is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: