Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix ICE when compiling impl block for ! #3179

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Commits on Sep 23, 2024

  1. rust: fix ICE when compiling impl block for !

    We need to resolve the never type which is its own special AST node so it
    doesnt magically get handled like the regular builtin type paths such as
    i32.
    
    Fixes #3035
    
    gcc/rust/ChangeLog:
    
    	* resolve/rust-ast-resolve-type.cc (ResolveType::visit):
    	handle never type
    	(ResolveTypeToCanonicalPath::visit): likewise
    	* resolve/rust-ast-resolve-type.h: missing never type
    	* resolve/rust-name-resolver.cc (Resolver::generate_builtins):
    	track never type node_id
    	(Resolver::setup_builtin): likewise
    	* resolve/rust-name-resolver.h: new never type getter
    
    gcc/testsuite/ChangeLog:
    
    	* rust/compile/nr2/exclude: nr2 cant handle this
    	* rust/compile/issue-3035.rs: New test.
    
    Signed-off-by: Philip Herron <herron.philip@googlemail.com>
    philberty committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    537fab8 View commit details
    Browse the repository at this point in the history