Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Explicitly install gettext for macos CI #3308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

powerboat9
Copy link
Contributor

This might fix the macos CI

ChangeLog:

	* .github/workflows/ccpp.yml: Add gettext to brew install list.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
@philberty
Copy link
Member

nice try looks like the error is:

checking for -single_module linker flag... clang++ -std=gnu++14  -I../../libcpp -I. -I../../libcpp/../include -I/usr/local/include -I../../libcpp/include -I/usr/local/include -g -O2     -W -Wall -Wno-narrowing -Wwrite-strings -Wmissing-format-attribute -pedantic -Wno-long-long  -fno-exceptions -fno-rtti -I../../libcpp -I. -I../../libcpp/../include -I/usr/local/include -I../../libcpp/include -I/usr/local/include   -c -o charset.o -MT charset.o -MMD -MP -MF .deps/charset.Tpo ../../libcpp/charset.cc
no
checking for -exported_symbols_list linker flag... In file included from ../../libcpp/charset.cc:21:
In file included from ../../libcpp/system.h:279:
/usr/local/include/libintl.h:1089:34: error: expected unqualified-id
char *setlocale (int __category, const char *__locale)
                                 ^
/usr/local/include/libintl.h:1089:34: error: expected ')'
/usr/local/include/libintl.h:1089:7: note: to match this '('
char *setlocale (int __category, const char *__locale)
      ^
../../libcpp/system.h:275:38: note: expanded from macro 'setlocale'
# define setlocale(category, locale) (locale)
                                     ^
yes

hard to tell without looking at the code directly

@powerboat9
Copy link
Contributor Author

It looks like everything would work if HAVE_SETLOCALE was defined, but I can't figure out where the configure script (?) is defining/not defining it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants