Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaults support for generics #401

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Add defaults support for generics #401

merged 2 commits into from
Apr 30, 2021

Conversation

philberty
Copy link
Member

This adds in the basic support for default arguments for generics such as:

struct Foo<A,B=f32>(A,B);

or recursive type params such as:

struct Foo<A, B = (A, A)>(A, B);

Fixes #307

@philberty
Apply defaults if available to type substitutions
feaafdf 
When we get defaults specified to Type parameters we must resolve the type
before insert the name into the name scope otherwise we can end up with
forward declared type parameters being resolved.

When we need to apply defaults during substitution we must check if they
themseleves need substitutions also with the mappings we have generated
so far.

Fixes #307
@philberty
Defaults to type params are not allowed here
2216cab
@philberty philberty self-assigned this Apr 30, 2021
@philberty
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 30, 2021

Build succeeded:

@bors bors bot merged commit b1dcbc3 into master Apr 30, 2021
@philberty philberty deleted the phil/generics9 branch May 9, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philberty philberty

Labels
enhancement
Projects
None yet
Milestone
Data Structures 2 - Generics
Development

Successfully merging this pull request may close these issues.

Generic parameters can have defaults
1 participant
@philberty