Ran cargo fmt + added some .context() calls for non-obvious errors
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh nice! I see we already have a |
|
hmmm noo I don't think so... it'd have to be in ~/rustfmt.toml right? |
|
ahh but now the imports didn't change back |
|
@tombh all right I think it's ready for review |
schell
requested changes
Mar 15, 2025
crates/cargo-gpu/src/build.rs
Outdated
| @@ -7,7 +7,6 @@ use std::io::Write as _; | |||
|
|
|||
| use crate::{install::Install, target_spec_dir}; | |||
| use spirv_builder_cli::{args::BuildArgs, Linkage, ShaderModule}; | |||
|
|
|||
There was a problem hiding this comment.
Was this removed by auto formatting?
crates/cargo-gpu/src/install.rs
Outdated
| @@ -1,4 +1,5 @@ | |||
| //! Install a dedicated per-shader crate that has the `rust-gpu` compiler in it. | |||
| //! | |||
There was a problem hiding this comment.
This should be a blank line, instead of a blank comment.
crates/cargo-gpu/src/install.rs
Outdated
| let mut file = std::fs::File::create(&path) | ||
| .with_context(|| format!("creating file at [{}]", path.display()))?; | ||
| file.write_all(contents.as_bytes()) | ||
| .context("writring to file")?; |
crates/cargo-gpu/src/install.rs
Outdated
| .context("getting command output") | ||
| .and_then(|output| { | ||
| log::trace!("STDOUT:\n{}", String::from_utf8_lossy(&output.stdout)); | ||
| log::trace!("STDERR:\n{}", String::from_utf8_lossy(&output.stderr)); |
There was a problem hiding this comment.
These lines shouldn't be necessary, since the command inherits stdin and stdout, right? Maybe I'm missing something though.
|
Thanks @Niedzwiedzw - just waiting for the CI checks and then I'll merge 👍 . |
schell
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.