Correctly calculate access chains for compound types #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My stuff still works with this branch (+ nonuniform patches) 🎉 |
|
My project compiled just fine and passes tests 👍 . I also successfully built a shader with Awesome work! |
schell
approved these changes
Apr 18, 2025
|
@eddyb said he wanted to take a look at this so I'll wait a bit before merging. |
|
Ok, I am just going to land it and we can fix forward or revert if it isn't correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46.
This was extremely painful and I am still not sure I understand the code completely and all the various cases.
@schell , @Firestar99 , please try it in your projects and see if I broke anything!