rustup: update to nightly-2025-06-23 (~1.89).
#320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
force-pushed
the
rustup-1.89
branch
14 times, most recently
from
78093b6 to
9b17fca
Compare
LegNeato
approved these changes
Jul 9, 2025
| let align_override = | ||
| Some(alloc.align).filter(|&align| align != self.lookup_type(value_ty).alignof(self)); | ||
| if let Some(_align) = align_override { | ||
| // FIXME(eddyb) implement, or at least error. |
There was a problem hiding this comment.
todo!() these? I don't know this code so don't know if needed.
There was a problem hiding this comment.
todo!() would ICE, it should at the very least be a nice user error if we do want to enforce it.
(otherwise, e.g. assert_eq!(alloc.align, self.lookup_type(value_ty).alignof(self)) is much better than a todo!(), but I don't think we should do either)
These things used to be ignored before, too, I just made the code slightly clearer that that's happening.
This was referenced Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to see this time, other than:
format_args!complications (less efficient codegen for some reason)-Zshare-generics=offnow being needed (because of weird special-casing done tocompiler-builtinsotherwise leaking to shader crates, via e.g.<Range<usize> as Iterator>>:next)clippy::collapsible_if, it's surprisingly applicable)