-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vulkan indirect command structs #34
Conversation
27088d7
to
c676db1
Compare
a7d9817
to
b3f8ec0
Compare
@@ -25,3 +26,4 @@ glam = { workspace = true, default-features = true } | |||
|
|||
[features] | |||
default = [] | |||
bytemuck = ["dep:bytemuck", "glam/bytemuck"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added bytemuck as an optional dependency to mark all the *IndirectCommand
structs as Pod, as most graphics APIs will require this. Should we make the bytemuck dependency required, eg. not hidden behind a feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping bytemuck
optional is good. It's true that most graphics projects will have it somewhere in the tree, but I don't think we should be deciding how folks marshal data to the GPU.
b3f8ec0
to
6cc7f95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me!
*IndirectCommand
structs from vulkan, mostly copied them from ash.Pod