Erase explicit layout decorations (Offset/ArrayStride) when disallowed by Vulkan.
#379
+937
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
force-pushed
the
erase-explicit-layout-sometimes-maybe
branch
2 times, most recently
from
3222ed1 to
0fd77cb
Compare
eddyb
force-pushed
the
erase-explicit-layout-sometimes-maybe
branch
from
0fd77cb to
707bdcc
Compare
eddyb
commented
Sep 10, 2025
Comment on lines
32
to
+36
| - if: ${{ runner.os == 'Windows' }} | ||
| name: Install Vulkan Runtime with SwiftShader (Windows) | ||
| uses: NcStudios/VulkanCI@v1.2 | ||
| with: | ||
| sdkVersion: 1.4.309.0 | ||
| sdkVersion: 1.4.321.0 |
There was a problem hiding this comment.
At the very least the Windows CI doesn't work, because this NcStudios/VulkanCI action is stuck on specific versions of the Vulkan SDK, not sure what to do about that - can we get SwiftShader from elsewhere?
There was a problem hiding this comment.
I only did swiftshader to work around a windows bug in their fake GPU thing. Actions are updating (actions/runner-images#12677) so maybe it isn't even needed now?
There was a problem hiding this comment.
(I also put up a PR for the action but who knows when it will get merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More recent Vulkan SDK versions have started complaining about types having explicit memory layout, when used with memory that doesn't inherently require explicit layouts (only push constants and buffers really do), e.g.:
The solution used here is simpler and more specialized (a pass that erases the explicit layout decorations from types behind pointers in storage classes that don't support them, combined with updating affected loads/stores) than what I originally described in #266 (comment), so we can hopefully use this for now and not worry about
spirt::{mem,qptr}for the next release.(not actually tested with MoltenVK, we should make sure it actually works now)
TODO: before landing this, we should update
spirv-tools-rsas well (I only changed the Vulkan SDK version that is used for CI, via theuse-installed-toolsfeature).