Skip to content

Switch arg parsing to clap-derive + small cargo refactor #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tranzystorekk
Copy link
Contributor

  • switch arg parsing to clap-derive
  • include Cargo.lock file

these small changes should nudge the project in a nice direction 😄

@John15321
Copy link
Contributor

@tranzystorek-io hi could you just change the target branch to be develop? :) We will merge it downstream later

@John15321 John15321 added the new feature New feature or request label Aug 1, 2022
@tranzystorekk tranzystorekk changed the base branch from main to develop August 1, 2022 14:38
@John15321 John15321 self-requested a review August 1, 2022 18:15
@John15321
Copy link
Contributor

@tranzystorek-io looks good. But some reason I cannot allow the CI to run on this PR :/ Im not sure how to do that

@tranzystorekk
Copy link
Contributor Author

@John15321 probably missing on: pull_request in workflow file

@John15321
Copy link
Contributor

@John15321 probably missing on: pull_request in the workflow file

You are right! I somehow forgot about that. Thanks. I will create an issue for that and add it. Then rebase your branch, then the CI should run and we can merge your changes 😄

@John15321
Copy link
Contributor

@tranzystorek-io could you rebase the branch now?

@John15321
Copy link
Contributor

John15321 commented Aug 1, 2022

@tranzystorek-io I know that this issue was present before your pr but could you please fix the issues present in the Code check job?

@John15321 John15321 merged commit 8a1284b into Rust-Python-Packaging:develop Aug 1, 2022
@tranzystorekk tranzystorekk deleted the clap-refactor branch August 1, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants