[WIP] Conversion fn prefixes: change to fit Rust's convention #1037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1036
Please review the changes.
I tried to strive to these rules, but I'm not sure about some of the changes I made. Most important to me was to change
Surface::as_texture()
toSurface::to_texture()
I'm not sure about
src/sdl2/joystick.rs
-sHatState::as_raw()
, because it's owned and I believe it's Copy, too, so according to the table it should beto_raw()
?