Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from 'match' to 'if' for string comparison. #53

Merged
merged 1 commit into from
Mar 15, 2014
Merged

Change from 'match' to 'if' for string comparison. #53

merged 1 commit into from
Mar 15, 2014

Conversation

dcbishop
Copy link
Contributor

No description provided.

@dcbishop
Copy link
Contributor Author

Should let it build again:

rustc -o './build/tmp/codegen' src/codegen/main.rs 
src/codegen/main.rs:28:17: 28:30 error: mismatched types: expected `~str` but found a `~`-box pattern
src/codegen/main.rs:28                 ~"keycode.rs" => keycode::generate(&output_dir),
                                       ^~~~~~~~~~~~~
src/codegen/main.rs:29:17: 29:31 error: mismatched types: expected `~str` but found a `~`-box pattern
src/codegen/main.rs:29                 ~"scancode.rs" => scancode::generate(&output_dir),
                                       ^~~~~~~~~~~~~~
error: aborting due to 2 previous errors
Makefile:39: recipe for target 'build/tmp/codegen' failed
make: *** [build/tmp/codegen] Error 101

Not sure if there is a way to get it working again match, still learning rust ☺.

@AngryLawyer
Copy link
Member

This is a valid solution :) Thanks

AngryLawyer added a commit that referenced this pull request Mar 15, 2014
Change from 'match' to 'if' for string comparison.
@AngryLawyer AngryLawyer merged commit c3145d9 into Rust-SDL2:master Mar 15, 2014
@drbawb
Copy link
Contributor

drbawb commented Mar 16, 2014

Doe anyone know which commit or issue this is on the mozilla/rust repo?

Not being able to match on strings seems like a pretty big change, it'd be great to read more about it.

@jmmk
Copy link
Contributor

jmmk commented Mar 17, 2014

Cobrand pushed a commit that referenced this pull request Dec 2, 2016
Cobrand pushed a commit that referenced this pull request Dec 2, 2016
jagprog5 pushed a commit to jagprog5/rust-sdl2 that referenced this pull request Jan 31, 2025
* update to raw-window-handle 0.6.2 and wgpu 23.0.1

* fix version

* remove hardcoded texture formats

* move unsafe impl to example code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants