Switch to CoercePointee macro, with examples #1130
Draft
+48
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 tasks
Darksonn
reviewed
Nov 20, 2024
Comment on lines
-444
to
-460
| // This is to allow coercion from `ListArc<T>` to `ListArc<U>` if `T` can be converted to the | ||
| // dynamically-sized type (DST) `U`. | ||
| impl<T, U, const ID: u64> core::ops::CoerceUnsized<ListArc<U, ID>> for ListArc<T, ID> | ||
| where | ||
| T: ListArcSafe<ID> + Unsize<U> + ?Sized, | ||
| U: ListArcSafe<ID> + ?Sized, | ||
| { | ||
| } | ||
|
|
||
| // This is to allow `ListArc<U>` to be dispatched on when `ListArc<T>` can be coerced into | ||
| // `ListArc<U>`. | ||
| impl<T, U, const ID: u64> core::ops::DispatchFromDyn<ListArc<U, ID>> for ListArc<T, ID> | ||
| where | ||
| T: ListArcSafe<ID> + Unsize<U> + ?Sized, | ||
| U: ListArcSafe<ID> + ?Sized, | ||
| { | ||
| } |
There was a problem hiding this comment.
We can't delete these due to support for older rustc releases. Please see this doc for info on conditional compilation.
There was a problem hiding this comment.
For reference, our current minimum version is 1.78.0, so you can use that to test.
There was a problem hiding this comment.
Okay, I will revert those chunks and wrap it with a conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft demonstrates the new capability from the current Rust Nightly, which now supports the
#[derive(CoercePointee)]macro to derive the key trait implementations, in place of use of unstable language features such asUnsizeandDispatchFromDyn.An illustrative example is attached for more details in the Rust sample kernel module.
TODO(@wieDasDing): work on the patch epilogue a bit more