Enable some lints and simplify CLIPPY=1
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
-Dnon_ascii_idents
-Drustdoc::missing_crate_level_docs
-Dclippy::suspicious
-Dclippy::mut_mut
-Dclippy::needless_bitwise_bool
-Dclippy::needless_continue
-Wclippy::dbg_macro
`dbg_macro` is left as a warning since developers may be using `CLIPPY=1`
for normal development.
We may want to change how the entire `CLIPPY=1` works, possibly moving
to `W=` anyway and always enabling it.
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Each tool including `rustc` itself, ignores unknown flags if in a namespace like `rustdoc::` or `clippy::`, thus we can keep all of them in a single list. Furthermore, we already skip Clippy for `core` and `alloc`. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
bjorn3
approved these changes
Nov 26, 2021
|
Thanks for the super quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies a bit the
Makefileand enables some extra lints:If some of these end up being too painful, we can always disable them later. But in general they sound like a good idea as long as they are not too annoying (i.e. an
allowhere or there). So far, most code "just worked". The only cases I had to change were:unreachable_pubhas found a few improvements already, and while its docs say it is pending some fixes on top, it seems good enough.let_unit_valuerequires a small change for the unit guard, but I think it makes the code a bit more clear anyway.I am also contemplating always using the Clippy driver and let kernel developers get accustomed to it -- i.e. no
CLIPPY=1anymore. This has the downside that it has a slight but noticeable performance penalty even if everything isallow(I guess it is going through the AST on its own, i.e. independently ofrustc, which I guess could be improved if it was integrated withrustcinstead). But it is not that big, so if Clippy upstream confirms there is no other downside apart from performance (rust-lang/rust-clippy#8035), then I think it may be the best path forward. In such a case, we could also consider moving some of them toW=instead, and possibly enabling others in other groups too.