rust: kernel: support !CONFIG_PRINTK
#669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/AN5PWUJVWHIFUUZYRJHXFGXBMSNUPSIL/ Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/AN5PWUJVWHIFUUZYRJHXFGXBMSNUPSIL/
Reported-by: kernel test robot lkp@intel.com
Signed-off-by: Miguel Ojeda ojeda@kernel.org
A note on the conditional compilation: short of automating it in some way one layer above in the bindings or using macros, I think this approach (similar to the one in the C side, though a bit more verbose) may be a good balance between disabling unused imports/variables warnings globally (too lax, even if only for a given config option) and for each parameter (very noisy).
It would be nice if there was an
allow(unused_parameters), i.e. more restricted than all variables. Or even better, a way to restrict theallowto the signature (without having to repeat it for each parameter and without losing the warning for the other case).