-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: implement Display
and Debug
for BStr
#893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
Implement `Display` and `Debug` for `BStr`. Also, for this purpose, change `BStr`, which previously was a type alias to `[u8]`, to a newtype of `[u8]`. Signed-off-by: Yutaro Ohno <yutaro.ono.418@gmail.com>
Display
and Debug
for BStr
Display
and Debug
for BStr
Just improved the commit message, especially adding a subsystem prefix. So no code change with force push. |
If this problem is not solved yet, I would like to contribute. |
@ohno418 Given we are in mainline, would you like to submit this to the list? |
Ah, yeah. I will submit this patch to the kernel mailing list later. |
Thanks to you! Cc'ing @Armavica in case they are still interested in sending their approach too -- it had tests, which was very nice. Also please consider if a |
Sure. Hi, @Armavica. Would it be okay if I mention you with a In case you find that a hassle, I'll just submit my patch to the list as it is. |
Hi @ohno418, thank you for your message, please feel free to use my tests and I would be happy to be mentioned as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been submitted to the list.
https://lore.kernel.org/rust-for-linux/ZbFBnXy7YWV0MFC0@ohnotp/
Implement
Display
andDebug
forBStr
. Also, for this purpose, changeBStr
from a type alias to a newtype wrapper.Closes #534
Similar PR here, but it seems to be out of date. And a little different from my PR.