Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kbuild: use panic=unwind for proc macros #91

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Conversation

ojeda
Copy link
Member

@ojeda ojeda commented Feb 20, 2021

Avoids the rust-lang/rust#82320 rustc crash.

Signed-off-by: Miguel Ojeda ojeda@kernel.org

Avoids the rust-lang/rust#82320 rustc crash.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@ojeda ojeda merged commit 9ba918a into rust Feb 20, 2021
@ojeda ojeda deleted the rust-proc-macro-unwind branch February 20, 2021 19:21
ojeda pushed a commit that referenced this pull request Jun 29, 2021
If a task is killed during a page fault, it does not currently call
sb_end_pagefault(), which means that the filesystem cannot be frozen
at any time thereafter.  This may be reported by lockdep like this:

====================================
WARNING: fsstress/10757 still has locks held!
5.13.0-rc4-build4+ #91 Not tainted
------------------------------------
1 lock held by fsstress/10757:
 #0: ffff888104eac530
 (
sb_pagefaults

as filesystem freezing is modelled as a lock.

Fix this by removing all the direct returns from within the function,
and using 'ret' to indicate whether we were interrupted or successful.

Fixes: 1cf7a15 ("afs: Implement shared-writeable mmap")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
Link: https://lore.kernel.org/r/20210616154900.1958373-1-willy@infradead.org/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants