Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement input focus for Mac & Windows #170

Merged
merged 9 commits into from
Mar 25, 2024
Merged

Conversation

dathinaios
Copy link
Contributor

As per #152. Still not working for VST but that appears to be due to a separate issue (see #169). I tested it in a nih_plug CLAP plugin in Reaper. I had to modify vizia_baseview to call set_input_focus when the alt-click event is triggered. Will also commit those changes there if this is accepted as a solution.

@micahrj
Copy link
Member

micahrj commented Mar 19, 2024

The Windows and Linux builds will fail without definitions of has_input_focus and set_input_focus on their platform::Window types. Please add some stub definitions with unimplemented!() to the Windows and Linux backends.

@dathinaios dathinaios changed the title Implement input focus for Mac Implement input focus for Mac & Windows Mar 21, 2024
src/macos/window.rs Outdated Show resolved Hide resolved
src/win/window.rs Outdated Show resolved Hide resolved
src/window.rs Outdated Show resolved Hide resolved
src/win/window.rs Outdated Show resolved Hide resolved
@micahrj micahrj merged commit bad50d8 into RustAudio:master Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants