-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement input focus for Mac & Windows #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows and Linux builds will fail without definitions of |
dathinaios
changed the title
Implement input focus for Mac
Implement input focus for Mac & Windows
Mar 21, 2024
httnn
reviewed
Mar 21, 2024
micahrj
reviewed
Mar 24, 2024
micahrj
reviewed
Mar 24, 2024
micahrj
reviewed
Mar 25, 2024
micahrj
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #152. Still not working for VST but that appears to be due to a separate issue (see #169). I tested it in a
nih_plug
CLAP plugin in Reaper. I had to modifyvizia_baseview
to callset_input_focus
when the alt-click event is triggered. Will also commit those changes there if this is accepted as a solution.