Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsRef and AsMut impls for AudioUnit #121

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

ori-sky
Copy link
Contributor

@ori-sky ori-sky commented Aug 7, 2024

This patch adds implementations of AsRef and AsMut for AudioUnit, providing access to the underlying sys::AudioUnit. This is needed in some cases where functionality is missing from coreaudio-rs or when interfacing with other code that requires the underlying sys::AudioUnit.

Copy link
Member

@simlay simlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem reasonable. Mind pulling latest master? I merged #123 to hopefully fix CI.

@ori-sky
Copy link
Contributor Author

ori-sky commented Aug 13, 2024

Thanks, rebased and pushed now.

Copy link
Member

@simlay simlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simlay simlay merged commit 01ff207 into RustAudio:master Aug 13, 2024
5 checks passed
@simlay simlay mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants