Add a feature for MacOS' IOKit/audio/IOAudioTypes.h #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying an AudioStream for its terminal type (kAudioStreamPropertyTerminalType) it will often return a value defined in IOAudioTypes.h (the ranges [INPUT_UNDEFINED, INPUT_MODEM_AUDIO] and [OUTPUT_UNDEFINED, OUTPUT_LOW_FREQUENCY_EFFECTS_SPEAKER]). This commit adds a feature io_kit_audio that will generate rust bindings for IOAudioTypes.h, so these enum values can be used in rust directly.
simlay
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
I don't really have any complaints about this addition. I think there's an argument for adding iOS support for the IOKit bindings but, eh.
If you want these changes be published to crates.io, bump to version = 0.2.14 in the Cargo.toml.
|
Thanks! Version bumped. |
simlay
approved these changes
Nov 15, 2023
|
Thanks! Could you merge, please? |
Done, was just waiting for CI to pass and then got distracted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying an AudioStream for its terminal type (kAudioStreamPropertyTerminalType) it will often return a value defined in IOAudioTypes.h (the ranges [INPUT_UNDEFINED, INPUT_MODEM_AUDIO] and [OUTPUT_UNDEFINED, OUTPUT_LOW_FREQUENCY_EFFECTS_SPEAKER]).
This commit adds a feature io_kit_audio that will generate rust bindings for IOAudioTypes.h, so these enum values can be used in rust directly.