ci: build fails for all non-release commits

[roderickvd]

CI currently fails on every commit that doesn't push a new version. The workflow appears to attempt releases on every push to master. This suggests the workflow was designed for a different branching strategy (feature/dev branches feeding into master for releases), but this model does not seem implemented.

Solution

Update .github/workflows/ to separate development builds from actual release builds:

if: startsWith(github.ref, 'refs/tags/v')
  # Release-only steps (publishing, version validation)
else:
  # Development steps (tests, clippy, fmt)

I would not mind manual cargo publish steps either - so without any workflow magic.

Request

@est31 would you please grant @roderickvd:

1. Maintainer access to CPAL repository (currently has collaborator)
2. RustAudio organization access (also contributes to Rodio)
3. Add to cpal-maintainers team on crates.io for cargo publish permissions

This access is needed to cut proper releases.

[simlay]

Huh. It's unclear to me why the cargo-publish job is is so complicated - I'm not saying it's wrong or bad, I genuinely don't know. I think you could remove the dry-run: true step and then throw a continue-on-error: true to get green builds.

I've been maintaining coreaudio-rs for ~5 years and the cargo publish just has a continue-on-error: true. There are times when I wish I could have HEAD on main/master to be an updated version without being published as I think that's how cargo-semver-checks action is suppose to be used.

Anyway, not trying to suggest hinder progress just offering some thoughts. I really appreciate cpal getting fresh eyes! If I had extra time, I'd offer to be a maintainer on the apple features.

[roderickvd]

Thanks for chiming in. Unless there's a specific reason, if it were up to me, we'd just keep master as the "nightly" development branch and tag releases off of it.

Anyway, not trying to suggest hinder progress just offering some thoughts. I really appreciate cpal getting fresh eyes! If I had extra time, I'd offer to be a maintainer on the apple features.

Contributions are welcome in any form or size as you can find the time - including this comment 👍

[yara-blue]

RustAudio organization access (also contributes to Rodio)

As maintainer of Rodio I second this

[est31]

Hi sorry for seeing this now. I see you are member of the RustAudio org and are also member of the cpal maintainers team. Anything more for me to do or can this be closed?

[roderickvd]

No worries. @simlay has proposed a PR in #997 to change the CI. After that this ticket can be closed.

[roderickvd]

Fixed in #1017