feat: add Stream::buffer_size() and improve AAudio buffer configuration #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add buffer_size() method to Stream trait that returns the number of frames passed to each data callback invocation (actual size or upper limit depending on platform). AAudio improvements: - BufferSize::Default now explicitly configures using optimal burst size from AudioManager, following Android low-latency audio best practices - buffer_size() query falls back to burst size if frames_per_data_callback was not explicitly set - Refactored buffer configuration to eliminate code duplication Addresses #1042 Relates to #964, #942
This was referenced Dec 23, 2025
Replace `Stream` enum with a struct containing `inner: Arc<Mutex<AudioStream>>` and `direction: DeviceDirection` fields. This eliminates code duplication while maintaining the same functionality.
roderickvd
force-pushed
the
feat/query-buffer-size
branch
from
60a92a5 to
401e5b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
buffer_size()method toStreamtrait that returns the number of frames passed to each data callback invocation (actual size or upper limit depending on platform).AAudio improvements:
BufferSize::Defaultnow explicitly configures using optimal burst size from AudioManager, following Android low-latency audio best practicesbuffer_size()query falls back to burst size ifframes_per_data_callbackwas not explicitly setAddresses #1042
Relates to #964, #942