Skip to content

Fix wasm-bindgen break #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderickvd merged 3 commits into from
Jan 4, 2026
Merged

Fix wasm-bindgen break #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b79b7b1
Fix wasm-bindgen break
kettle11 Jan 3, 2026
dde19d6
Update Github Actions to test wasm-bindgen building via Trunk and upd…
kettle11 Jan 3, 2026
f885650
ci: enforce MSRV for trunk build steps
kettle11 Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions .github/workflows/platforms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,11 @@ jobs:
toolchain: ${{ env.MSRV_WASM }}
targets: ${{ env.TARGET }}

- name: Install Trunk
uses: taiki-e/install-action@v2
with:
tool: trunk

- name: Rust Cache
uses: Swatinem/rust-cache@v2
with:
Expand All @@ -409,9 +414,11 @@ jobs:
- name: Check examples (wasm-bindgen feature)
run: cargo +${{ env.MSRV_WASM }} check --examples --features wasm-bindgen --workspace --verbose --target ${{ env.TARGET }}

- name: Check wasm-beep example
working-directory: examples/wasm-beep
run: cargo +${{ env.MSRV_WASM }} check --verbose --target ${{ env.TARGET }}
- name: Build wasm-beep example
working-directory: ./examples/wasm-beep
run: trunk build
env:
RUSTUP_TOOLCHAIN: ${{ env.MSRV_WASM }}

# WebAssembly - AudioWorklet
wasm-audioworklet:
Expand All @@ -428,6 +435,11 @@ jobs:
targets: ${{ env.TARGET }}
components: rust-src

- name: Install Trunk
uses: taiki-e/install-action@v2
with:
tool: trunk

- name: Rust Cache
uses: Swatinem/rust-cache@v2
with:
Expand All @@ -436,9 +448,11 @@ jobs:
- name: Check examples (audioworklet feature)
run: cargo +nightly check --examples --features audioworklet --workspace --verbose -Z build-std=std,panic_abort --target ${{ env.TARGET }}

- name: Check audioworklet-beep example
working-directory: examples/audioworklet-beep
run: cargo +nightly check -Z build-std=std,panic_abort --verbose --target ${{ env.TARGET }}
- name: Build audioworklet-beep example
working-directory: ./examples/audioworklet-beep
run: trunk build
env:
RUSTUP_TOOLCHAIN: nightly

# WebAssembly - WASI Preview 1
wasm-wasip1:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- **ALSA**: Device enumeration now includes both hints and physical cards.
- **JACK**: No longer builds on iOS.
- **Wasm**: Fixes a regression introduced in 0.17.0 that would cause WasmBindgen to crash.

### Changed

Expand Down
4 changes: 3 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ pub enum BufferSize {
any(target_os = "emscripten", feature = "wasm-bindgen")
))]
impl wasm_bindgen::describe::WasmDescribe for BufferSize {
fn describe() {}
fn describe() {
<Option<FrameCount> as wasm_bindgen::describe::WasmDescribe>::describe();
}
}

#[cfg(all(
Expand Down