Rebase/Update webaudio PR for recent breaking changes #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rebases RustAudio#372, addressing the recent changes introduced by RustAudio#397, RustAudio#395, and RustAudio#371 in the process. TODO: - [ ] Complete implementation of `callback` and `playback` timestamps in the output stream callback.
mitchmindtree
force-pushed
the
webaudio-poc-rebased
branch
from
c173c55 to
640a1d3
Compare
Member
Author
|
OK, I think it's time to merge this. Thanks again @dpeckett! There are quite a few things left to implement, but I'll open up separate issues for the remaining work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases @dpeckett 's awesome work on #372, addressing the recent changes introduced by #397, #395, and #371 in the process.
TODO:
callbackandplaybacktimestamps in the output stream callback.