[ALSA] Improve stream setup parameters. #520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Always set period before setting buffer size, even if `BufferSize::Fixed`. * Set `start_threshold` based on `alsa::Direction` to avoid underruns on playback streams. Also refactor the return values of the set params functions to reflect their actual use and resolve some clippy warnings (including a logic error in `stream_timestamp()`).
This was referenced Dec 23, 2020
Contributor
Author
|
@mitchmindtree I think this PR is ready to merge. Let me know if you see anything blocking it. |
|
Hi, what is the status of this? It seems that merging this would unblock progress outlined in #495 (comment), which would help our adoption of |
Member
|
This PR has a conflict. I am ready to merge it but they need to be resolved. |
The conflict was easy to resolve, but I cannot push to @alexmoon's branch. Let's give Alex a bit more time to react. In any case the rebased branch is at master...strohel:alsa-setup |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferSize::Fixed.start_thresholdbased onalsa::Directionto avoid underruns on playback streams.Also refactor the return values of the set params functions to reflect their actual use and resolve some clippy warnings (including a logic error in
stream_timestamp()).This pull request incorporates the changes from @sniperrifle2004 in #433 and #431. Based on that it should fix #369, fix #391 and fix #432.