Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default port selection parameters for PipeWire compatibility #556

Closed
wants to merge 1 commit into from
Closed

Fix default port selection parameters for PipeWire compatibility #556

wants to merge 1 commit into from

Conversation

ishitatsuyuki
Copy link
Collaborator

Ref: #554

Be-ing
Be-ing reviewed Mar 18, 2021
View reviewed changes
src/host/jack/stream.rs
None,
jack::PortFlags::empty(),
Some(FLOAT_MONO_AUDIO),
jack::PortFlags::IS_INPUT | jack::PortFlags::IS_PHYSICAL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this just guesses to use an arbitrary hardware device?

@Be-ing
Copy link
Contributor

Be-ing commented Mar 18, 2021

If the intention for the cpal API is to access the sound server's default hardware interface, I think it might be best to leave it as is using system. According to this PipeWire issue, PipeWire should provide a system JACK device but this seems to not work properly yet.

@ishitatsuyuki
Copy link
Collaborator Author

Okay, closing this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishitatsuyuki @Be-ing