Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DynamicMixer and OutputStream generic #547

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make DynamicMixer and OutputStream generic #547

wants to merge 3 commits into from

Commits on Mar 5, 2024

  1. Make DynamicMixer and OutputStream generic 

    This commit adds a new trait, `Mixer`, and refactors some of the
code around generic mixers in order to support it. This is to
make more of the code reusable without rewriting - specifically,
to support a feature that I would like to implement in
`bevy_audio` where audio sources can send audio to an
intermediate mixer. The motivation for this was to add a global
limiter to all game audio, so that loud sounds did not cause
clipping on the master bus, but another possible usecase would
be to split in-game audio and menu audio into separate "worlds"
and apply, for example, a low-pass filter while in the pause
screen.
    @eira-fransham
    eira-fransham committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    c21343a View commit details
    Browse the repository at this point in the history

  2. Fix mixer not implementing sync

    @eira-fransham
    eira-fransham committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    fc08c07 View commit details
    Browse the repository at this point in the history

  3. Remove sync bounds from mixer

    @eira-fransham
    eira-fransham committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1031592 View commit details
    Browse the repository at this point in the history