Implement trait AeadInto for AES-GCM and ChaCha20-Poly1305 #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addendum: It's perfectly acceptable to replace the pregenerated test data if so preferred. I only wanted non-zero, non-empty test data to confirm that encrypt_into and decrypt_into would work as expected with realistic parameters. |
|
Retracted, as I am currently in progress writing the implementation for an alternative proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on this PR!
Resolves this issue.
Notes
I only implement
AeadIntofor AES-GCM and ChaChaPoly because these are the algorithms officially supported by the Noise Protocol Framework (the driving factor behind my PR).While I'm not personally invested in doing so, let me know if you need me to implement
AeadIntofor the other algorithms in order to accept this PR.