Add real CI for ML-KEM #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Mar 2, 2024
tarcieri
reviewed
Mar 2, 2024
tarcieri
reviewed
Mar 2, 2024
|
@tarcieri Assuming the MIRI CI run succeeds, I think this is good to merge as long as you're happy with it. |
tarcieri
reviewed
Mar 2, 2024
Co-authored-by: Tony Arcieri <bascule@gmail.com>
|
It's possible the Miri tests will be too slow, in which case I'd suggest testing on a big endian target with |
|
Would probably just suggest removing Miri for now. The tests have been running for a half hour. I can follow up with cross for a big endian platform to test that. |
|
Looks like Miri completed successfully after 40 minutes. Will go ahead and merge this then. I can follow up to switch Miri to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stub CI added in #3 has a bunch of sections commented out. This PR is to remove those comments (so that the sections are active) and fix any bugs that are found.