hmac v0.12 #97
Merged
hmac v0.12 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
commented
Nov 19, 2021
| /// Generic core HMAC instance, which operates over blocks. | ||
| pub struct HmacCore<D> | ||
| where | ||
| D: CoreProxy, |
There was a problem hiding this comment.
We could simplify bounds a bit by being generic over D: HashMarker + UdpateCore + FixedOutputCore + .., but it would mean that users will have to use "core" types to construct a concrete HMAC type, i.e. Hmac<Sha256Core> instead of Hmac<Sha256>.
This was referenced Nov 19, 2021
newpavlov
force-pushed
the
hmac/v0.12
branch
3 times, most recently
from
8b81e84 to
c0dbef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split-off from #95
Depends on RustCrypto/traits#819 and RustCrypto/hashes#217
Notable changes:
Hmacnow works only with hash functions which process blocks eagerly and expose block-level API (i.e. all hashes implemented in RsutCrypto/hashes except BLAKE2). It allows to use a bit more efficient state representation.SimpleHmacis introduced as an alternative toHmacwhich works overDigestand uses simpler code.resetfeature.