Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

padding: ensure PaddingScheme is Send and Sync #215

Merged
merged 1 commit into from
Oct 24, 2022
Merged

padding: ensure PaddingScheme is Send and Sync #215

merged 1 commit into from
Oct 24, 2022

Conversation

gdesmott
Copy link
Contributor

It's more convenient for users.

Fix #214

@gdesmott
Copy link
Contributor Author

Do we want Sync as well?

@gdesmott gdesmott mentioned this pull request Oct 20, 2022
Closed
@gdesmott
Copy link
Contributor Author

Do we want Sync as well?

Added it as it's free and more convenient.

@gdesmott gdesmott changed the title padding: ensure PaddingScheme is Send padding: ensure PaddingScheme is Send and Sync Oct 20, 2022
@tarcieri
Copy link
Member

This is technically a breaking change, although probably one which won't lead to breakages in practice

@tarcieri tarcieri merged commit a857c8f into RustCrypto:master Oct 24, 2022
@tarcieri tarcieri mentioned this pull request Oct 31, 2022
Merged
@tarcieri tarcieri mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PaddingScheme being !Send makes things harder
2 participants
@gdesmott @tarcieri