Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Encryption-related traits #259

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Conversation

lumag
Copy link
Contributor

@lumag lumag commented Feb 7, 2023

Follow the signing API and add a set of traits to be used for data encryption and decryption.

lumag added 2 commits February 8, 2023 00:39
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
There is little point in having only OAEP test cases in src/key.rs. Move
them to proper module, oaep.rs.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
src/oaep.rs Show resolved Hide resolved
src/traits.rs Outdated Show resolved Hide resolved
Currently the crate doesn't mark the oaep module as public. Thus it
makes little sense to mark top-level functions as public. Drop the
modifier.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I really like this API, and the traits that sort of mirror the signature crate

lumag added 2 commits February 8, 2023 01:21
Add traits following the signature design for encryption and decryption.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Add new EncryptingKey and DecryptingKey structs implementing Encryptor /
Decryptor traits.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@tarcieri tarcieri merged commit dacabfc into RustCrypto:master Feb 13, 2023
@tarcieri tarcieri mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants