Fix 2049 bit RSA issues and roundtrip PKCS#1 and PKCS#8 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 tasks
The `n` in both cases is 257 bytes, with first element being 0 Re-encoded the number into 256 bytes and now the decoding works. Note that ff you want to keep the previous Base64 `n`, then the BoxedUint must take 2056 as the `bits_precision` parameter
|
thanks a lot! will take a closer look when back on my computer |
dignifiedquire
merged commit e15b6a4
into
RustCrypto:const-crypto-biguint
4 of 11 checks passed
|
merged manually, thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues in tests in #394
The problem exists because BigUint usually have leading zeroes and the equality checks fail because of that. Now the PKCS#1 and PKCS#8 tests parse the hex number into a BigUint and the equality is checked between them. As for the 2049 bit RSA signing/verification issue, that also was caused by leading zeroes in the left_pad method.