Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sha2): add aarch64 implementation for sha256 for the M1 chip #35

Merged
merged 4 commits into from
May 4, 2021

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented May 4, 2021

Fixes the sha2 part of #28

@tarcieri
Copy link
Member

tarcieri commented May 4, 2021

I can confirm this at least builds on my M1 Mac Mini.

Seems like it might be good to have some basic smoke tests in these repos.

@dignifiedquire
Copy link
Member Author

dignifiedquire commented May 4, 2021

I have tested this with: RustCrypto/hashes#261 which patches this branch in and enables the usage of asm on macos.

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my end-to-end tests of RustCrypto/hashes#261 this appears to be working

@tarcieri tarcieri merged commit 5657d94 into RustCrypto:master May 4, 2021
@tarcieri tarcieri mentioned this pull request May 5, 2021
tarcieri added a commit to RustCrypto/hashes that referenced this pull request May 5, 2021
This release includes support for Apple M1 CPUs:

RustCrypto/asm-hashes#35
tarcieri added a commit to RustCrypto/hashes that referenced this pull request May 5, 2021
This release includes support for Apple M1 CPUs:

RustCrypto/asm-hashes#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants