Reverse order of Concat/Split arguments?
#519
Comments
tarcieri
added a commit
that referenced
this issue
Dec 27, 2023
Changes to a "little endian" `lo, hi` convention for the ordering of
arguments to concatenation methods and the ordering of the returned
2-tuple from split methods.
This is more consistent with the rest of the crate, and the
`Uint { limbs }` which uses a little endian ordering.
Closes #519
tarcieri
added a commit
that referenced
this issue
Dec 28, 2023
Changes to a "little endian" `lo, hi` convention for the ordering of
arguments to concatenation methods and the ordering of the returned
2-tuple from split methods.
This is more consistent with the rest of the crate, and the
`Uint { limbs }` array which uses a little endian ordering.
Closes #519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This crate uses a little endian limb ordering, with the least significant limbs first and the most significant last.
#34 reversed return tuples for functions like
mul_wideto return(lo, hi)rather than(hi, lo). However,Concat(Mixed)andSplitstill use a hi/lo ordering.I would suggest reversing this for consistency, so the ordering is consistent with the ordering of the limbs themselves.
The text was updated successfully, but these errors were encountered: