Faster decoding for UInt #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this machine these changes take
Encoding::from_{le|be}_bytesfrom around 200ns to around 3ns for a U256. It adds non-const (but still constant-time) methods for decoding UInts from a byte array.Restricting the input to an array allows the assert to be optimized out, as is the
unreachable!()panicking according to godbolt. But there may be a cleaner way to obtain the fixed-size chunks (for example, copying into an intermediate buffer), and in futureslice::as_chunkscould be applicable.