Add support for Binary and Decimal encodings #246
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decimal serialization (outside of
write_decimal_bytes_vartime
) is currently only supported when the alloc flag is enabled, as the encoded length is potentially unbounded forUint<L>
and digits are produced in reverse. In practice anything up toU8192
can be encoded without allocating. Note that unlike the other encodings, decimal encoding is not constant-time.Unresolved questions:
FromDecimal
? This is a bit tricky as it would require thealloc
feature (or gain additional methods when the feature is enabled).Error
forParseDecimalError
? This would require astd
flag.