Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitwise xor and not #27

Merged
merged 5 commits into from
Oct 17, 2021
Merged

Conversation

kaidokert
Copy link
Contributor

Mostly a copy from @Jperaire and/or implementation in #25

@tarcieri
Copy link
Member

Needs rustfmt.

It seems I didn't notice the module names are inconsistent between limb and uint in #25. Anyway, I'd suggest making them consistent with the bit* prefix added in both cases. If you could do and and or as well for uint that'd be great.

Proptests would also be nice if you're interested in adding them. Otherwise I can merge without them and add them later.

@kaidokert
Copy link
Contributor Author

I think i covered most of the feedback, but i can't find core::ops::Not implementation in num_bigint::BigUint, unsure as to how to write a clean proptest for it.

@kaidokert kaidokert marked this pull request as ready for review October 17, 2021 01:47
@tarcieri tarcieri merged commit b215b29 into RustCrypto:master Oct 17, 2021
@tarcieri
Copy link
Member

Thanks!

@tarcieri tarcieri mentioned this pull request Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants