Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k256: ecdsa::{Signer, Verifier} newtypes #108

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Aug 3, 2020

Adds newtypes for ECDSA signing and verification which support k256::ecdsa::recoverable::Signature in addition to k256::ecdsa::Signature.

This allows the signature type to be selected by the return value.

Adds newtypes for ECDSA signing and verification which support
`k256::ecdsa::recoverable::Signature` in addition to
`k256::ecdsa::Signature`.

This allows the signature type to be selected by the return value.
@tarcieri tarcieri force-pushed the k256/ecdsa-newtypes branch from 3368c9b to 3956032 Compare August 3, 2020 19:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #108 into master will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   52.46%   52.02%   -0.44%     
==========================================
  Files          19       20       +1     
  Lines        3431     3460      +29     
==========================================
  Hits         1800     1800              
- Misses       1631     1660      +29     
Impacted Files Coverage Δ
k256/src/arithmetic/scalar/scalar_4x64.rs 76.55% <ø> (ø)
k256/src/ecdsa/recoverable.rs 0.00% <0.00%> (ø)
k256/src/ecdsa/signer.rs 0.00% <0.00%> (ø)
k256/src/ecdsa/verifier.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ae6fd...3956032. Read the comment docs.

@tarcieri tarcieri merged commit 29e98d6 into master Aug 3, 2020
@tarcieri tarcieri deleted the k256/ecdsa-newtypes branch August 3, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants