Missing formats

[tarcieri]

• PKCS#1: RSA Cryptography Standard
• PKCS#5: Password-based Encryption Standard
• PKCS#7: Cryptographic Message Syntax Standard support #28
• PKCS#8: Private-Key Information Syntax Standard
• PKCS#10: Certification Request Standard
• PKCS#12 / PFX support #3
• SPKI: X.509 Subject Public Key Info
• X.509: Public Key Infrastructure Certificate and Certificate Revocation List (CRL) Profile

Please post a comment to request additional formats

[jklong]

#3 will also require a PKCS#7 implementation so I'll start work on that as well. I've created PKCS#7 support #28 to track.

[franziskuskiefer]

Do you want to stick to the big ones or are you also interested in things like the "TLS codec". It's not really a standard but it's being used quite a bit by now. I have a version here https://github.com/openmls/tls-codec/

[tarcieri]

@franziskuskiefer if you so happen to be looking for another home for it I'd say that would be a great thing to have here

[jonasbb]

The new ssh-key crate does not seem to support ssh-keys backed by security keys, which contain the sk suffix in the name. There is ecdsa_sk which uses sk-ecdsa-sha2-nistp256@openssh.com in the .pub file and ed25519_sk using sk-ssh-ed25519@openssh.com as the identifier.
It would be great to have support for these newer key types too, but it is not clear to me if that is currently on the todo list.

[tarcieri]

@jonasbb yes, it would be good to add support for those. Likewise it would be nice to have support for OpenSSH certificates.

I will try to get these items added to the TODO list in the README, or otherwise would merge a PR to add them.

[enri1196]

Do you think RFC3161 TimeStamp Protocol would be a good addition to the formats?

reference: https://www.rfc-editor.org/rfc/rfc3161

[carl-wallace]

I think RFC3161 would be a good addition and have thought about implementing it before but had not gotten around to it. It's referenced in some new work, for example, draft-birkholz-rats-epoch-markers.

[enri1196]

I'd like to help, can I just open a PR once I've got some basic implementation of the structures? Maybe a new folder under formats/tsp?

[tarcieri]

We'd need a crate name we actually control, although you can use that name temporarily until we pick one we do control

[leotaku]

I would potentially be interested in contributing an implementation of RFC5544. Is that something the project would benefit from?

[enri1196]

Hey @leotaku I've actually created an issue for this format and I have most of the work done locally, the blocking issue for me is that I get an indefinite length error which seems to come from a BER/DER mixed encoding. #1198 I was waiting to get some feedback, but I could definitely open a PR for you to test for your self, maybe you can spot something i missed.

[leotaku]

@enri1196 That sounds great. If you open a PR or direct me to your fork I'd love to take a look.