pkcs7: deprecate in favor of cms
#1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tarcieri
force-pushed
the
deprecate-pkcs7-crate
branch
from
a214cd8 to
9d03ace
Compare
This commit adds a deprecation notice to README.md for the `pkcs7` crate announcing `cms` as its official successor. Notably `pkcs7` predates many of the other format-related crates and uses entirely reference-based conventions which we migrated away from in the `x509-cert` crate. `cms` uses the newer conventions, and is more complete as a Cryptographic Message Syntax implementation. We will not be accepting pull requests for `pkcs7` and are leaving its source code for now only to aid in porting functionality not yet present in the `cms` crate. When the next breaking release of `der` occurs, we will delete the `pkcs7` source code from the repository, leaving only the deprecation notice to help assist people migrating. Closes #1045.
tarcieri
force-pushed
the
deprecate-pkcs7-crate
branch
from
9d03ace to
ce2886e
Compare
baloo
added a commit
to baloo/formats
that referenced
this pull request
Jul 14, 2023
Added - `SignedData` builder (RustCrypto#1051) Changed - Deprecate `pkcs7` in favor of `cms` (RustCrypto#1062) - der: add `SetOf(Vec)::insert(_ordered)`; deprecate `add` (RustCrypto#1067) - Re-enable all minimal-versions checks (RustCrypto#1071) Fixed - Don't insert signing time attribute by default (RustCrypto#1148) - Fixed encoding of `SubjectKeyIdentifier` (RustCrypto#1152)
Merged
baloo
added a commit
that referenced
this pull request
Jul 14, 2023
Added - `SignedData` builder (#1051) Changed - Deprecate `pkcs7` in favor of `cms` (#1062) - der: add `SetOf(Vec)::insert(_ordered)`; deprecate `add` (#1067) - Re-enable all minimal-versions checks (#1071) Fixed - Don't insert signing time attribute by default (#1148) - Fixed encoding of `SubjectKeyIdentifier` (#1152)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a deprecation notice to README.md for the
pkcs7crate announcingcmsas its official successor.Notably
pkcs7predates many of the other format-related crates and uses entirely reference-based conventions which we migrated away from in thex509-certcrate.cmsuses the newer conventions, and is more complete as a Cryptographic Message Syntax implementation.We will not be accepting pull requests for
pkcs7and are leaving its source code for now only to aid in porting functionality not yet present in thecmscrate.When the next breaking release of
deroccurs, we will delete thepkcs7source code from the repository, leaving only the deprecation notice to help assist people migrating.Closes #1045.