Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509-cert: fixup RDN string representation #1126

Merged
merged 2 commits into from
Jun 27, 2023
Merged

x509-cert: fixup RDN string representation #1126

merged 2 commits into from
Jun 27, 2023

Conversation

baloo
Copy link
Member

@baloo baloo commented Jun 27, 2023

Fixes #1121

@baloo baloo mentioned this pull request Jun 27, 2023
Closed
@baloo baloo changed the title x509-cert: fixup string representation x509-cert: fixup RDN string representation Jun 27, 2023
@baloo baloo force-pushed the baloo/x509-cert/name-string-ordering branch from 31cd225 to 1fd2852 Compare June 27, 2023 22:10
tarcieri
tarcieri requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, integration test failure:

---- rdns_serde stdout ----
output: CN=foo,SN=bar,C=baz+L=bat
thread 'rdns_serde' panicked at 'assertion failed: `(left == right)`
  left: `"CN=foo,SN=bar,C=baz+L=bat"`,
 right: `"C=baz+L=bat,SN=bar,CN=foo"`', tests/name.rs:346:9

@baloo
Copy link
Member Author

baloo commented Jun 27, 2023

yeah, this needs the same fix on the parsing side.

@baloo baloo merged commit f36bcbb into RustCrypto:master Jun 27, 2023
@baloo baloo deleted the baloo/x509-cert/name-string-ordering branch June 27, 2023 23:12
baloo added a commit to baloo/formats that referenced this pull request Jul 25, 2023
@baloo
x509-cert v0.2.4
58cec66 
Added
- `add_attribute` to `RequestBuilder` ([RustCrypto#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([RustCrypto#1122])
- use the shortest name when looking attr OID ([RustCrypto#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([RustCrypto#1158])

Fixed
- RDN string representation ([RustCrypto#1126])
- `Arbitrary` for certificates ([RustCrypto#1150])

[RustCrypto#1122]: RustCrypto#1122
[RustCrypto#1126]: RustCrypto#1126
[RustCrypto#1130]: RustCrypto#1130
[RustCrypto#1137]: RustCrypto#1137
[RustCrypto#1150]: RustCrypto#1150
[RustCrypto#1158]: RustCrypto#1158
@baloo baloo mentioned this pull request Jul 25, 2023
Merged
baloo added a commit that referenced this pull request Jul 25, 2023
@baloo
x509-cert v0.2.4 (#1170)
dc5a611 
Added
- `add_attribute` to `RequestBuilder` ([#1137])

Changed
- bump `serde_json` from 1.0.97 to 1.0.99 ([#1122])
- use the shortest name when looking attr OID ([#1130])
- bump `serde_json` from 1.0.100 to 1.0.103 ([#1158])

Fixed
- RDN string representation ([#1126])
- `Arbitrary` for certificates ([#1150])

[#1122]: #1122
[#1126]: #1126
[#1130]: #1130
[#1137]: #1137
[#1150]: #1150
[#1158]: #1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x509-cert: RdnSequence.to_string() not producing RFC4514 compliant string representations
2 participants
@baloo @tarcieri