Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509-cert: remove unnecessary builder feature activations #1709

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MihaelBercic
Copy link

  • Removed sha1/default, since that includes std feature.
  • Set der to the latest rc version.
  • Used dep: syntax for feature based dependencies

Note: I was unable to run all tests due to not having the zlint installed.

@@ -17,13 +17,13 @@ rust-version = "1.81"

[dependencies]
const-oid = { version = "0.10.0-rc.0", features = ["db"] }
der = { version = "0.8.0-rc.0", features = ["alloc", "derive", "flagset", "oid"] }
der = { version = "0.8.0-rc.1", features = ["alloc", "derive", "flagset", "oid"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary, this is already tracked in the Cargo.lock

@baloo
Copy link
Member

baloo commented Mar 12, 2025

Can we get back to that once #1689 merges?

@tarcieri tarcieri changed the title Default features x509-cert: remove unnecessary builder feature activations Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants